Conversation
JakobJingleheimer
approved these changes
Jan 16, 2026
Member
JakobJingleheimer
left a comment
JakobJingleheimer
left a comment
There was a problem hiding this comment.
Thanks for handling this :)
Comment on lines
+310
to
+312
| ls.on('close', (code) => { | ||
| tt.equal(code, 1, 'CLI exits with non-zero code on error') | ||
| tt.match(errorData, /Input must be an array/, 'error message is shown') |
Member
There was a problem hiding this comment.
This seems likely to create bad DX. If it's not an array, just wrap it in an array.
Contributor
Author
There was a problem hiding this comment.
If there's a use-case for passing a non-array, we can consider it. Until then, it's probably more helpful to throw an error.
Member
There was a problem hiding this comment.
I meant I think it's a likely mistake a user could make, and throwing will just especially frustrate the user "god dammit" because they'll likely know how easy it was to just handle it.
Co-authored-by: Jacob Smith <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to remove the need to clone the repo in https://github.com/nodejs/node/blob/main/.github/workflows/notify-on-push.yml, and instead rely on
push.commitslike so: